Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A major change the the API was made in
v8
to seperate concerns between the different SQL statement types.Why the change?
ToInsertSQL
,ToUpdateSQL
etc.) took arguments which lead to an ugly API that was not uniform for each statement type, and proved to be inflexible.What Changed
There are now five dataset types,
SelectDataset
,InsertDataset
,UpdateDataset
,DeleteDataset
andTruncateDataset
Each dataset type has its own entry point.
goqu.From
,Database#From
,DialectWrapper#From
- Create SELECTgoqu.Insert
,Database#Insert
,DialectWrapper#Insert
- Create INSERTgoqu.Update
,Database#db.Update
,DialectWrapper#Update
- Create UPDATEgoqu.Delete
,Database#Delete
,DialectWrapper#Delete
- Create DELETEgoqu.Truncate
,Database#Truncate
,DialectWrapper#Truncate
- Create TRUNCATEToInsertSQL
,ToUpdateSQL
,ToDeleteSQL
, andToTruncateSQL
(and variations of them) methods have been removed from theSelectDataset
. Instead use theToSQL
methods on each dataset type.Each dataset type will have an
Executor
andToSQL
method so a common interface can be created for each type.